feat(graphql_parser): parse enum extension #3044
Conversation
CodSpeed Performance ReportMerging #3044 will not alter performanceComparing Summary
|
vohoanglong0107
force-pushed
the
feat-graphql-enum-extension
branch
from
2b6e286
to
d1de19c
Compare
| let m = p.start(); | ||
|
|
||
| p.bump(T![extend]); | ||
| p.bump(T![enum]); |
There was a problem hiding this comment.
| p.bump(T![enum]); | |
| p.expect(T![enum]); |
There was a problem hiding this comment.
I don't know if this is truly necessary, as this parsing rule should only be called in one place (here), and we must have already checked for the presence of both tokens before advancing. Correct me if you think otherwise.
There was a problem hiding this comment.
Yeah, it’s not a blocker, but it’s good practice for the parser functions to validate their preconditions instead of assuming to be called correctly. It wouldn’t change anything functionally now, but it makes the contract more explicit and brings some extra robustness in the face of future changes to the parser.
Summary
Parse GraphQL enum extensions (link). Once this is completed, we will only have input object extensions (link) remaining before the GraphQL parser is ready for benchmarking.
Test Plan
All tests should pass